Remove unused RTD files (extra RTD, extra requirements.txt) #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some missing packages in `setup.py`[docs] compared to online_docs/requirement.txt Here we make sure both have the same stuff. TBH -- do we need anything in online_docs/requirement.txt? Or even `requirements.txt`? Isnt everything in `setup.py`?
avivajpeyi
changed the title
jeffriley
approved these changes
Dec 5, 2024
Collaborator
jeffriley
left a comment
jeffriley
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @avivajpeyi
Collaborator
|
@avivajpeyi -- I think this might be related to the latest changes: CI is failing, again. Error: No file in /home/runner/work/COMPAS/COMPAS matched to [**/requirements.txt or **/pyproject.toml], make sure you have checked out the target repository (e.g., https://github.com/TeamCOMPAS/COMPAS/actions/runs/12175865123 ) |
Collaborator
Author
|
This is rather embarrassing... I didnt think that there would be any side effects! I thought I searched for all references to Ill fix this ASAP |
Collaborator
Author
|
Fixed in #1306 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo has a bunch of extra, unsused requirements.txt files, while all the requirements are already in the
setup.py.This PR removes the redundant
requirements.txtfiles, ane updates thesetup.pywith the correct versions from the old requirements.txt.This PR also removes an extra duplicate of an older version of the RTD config file (there should only be one file).